Skip to content

fixes: DASH-541 #5636

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 5, 2024
Merged

fixes: DASH-541 #5636

merged 1 commit into from
Dec 5, 2024
+7 −29

Conversation

@jnsdls
Copy link
Member

@jnsdls jnsdls commented Dec 5, 2024 •
edited by pr-codex bot
Loading

PR-Codex overview

This PR focuses on improving the handling of the MaskedAvatar component's rendering logic and cleaning up the profile page by removing unused code related to Open Graph image generation.

Detailed summary

  • Added a conditional check to return null for MaskedAvatar if certain states are pending and publisherImageUrl is not available.
  • Removed the fetching of publisherProfile and handling for cases where it is not found.
  • Deleted commented-out code related to Open Graph image generation.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@linear
Copy link

linear bot commented Dec 5, 2024

DASH-541 [Bug] Publish link erroring out for ZetaChain team

@changeset-bot
Copy link

changeset-bot bot commented Dec 5, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: b2b95a5

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Dec 5, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 5, 2024 11:13pm
3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs-v2 ⬜️ Skipped (Inspect) Dec 5, 2024 11:13pm
thirdweb_playground ⬜️ Skipped (Inspect) Dec 5, 2024 11:13pm
wallet-ui ⬜️ Skipped (Inspect) Dec 5, 2024 11:13pm

@vercel vercel bot temporarily deployed to Preview – wallet-ui December 5, 2024 22:01 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 December 5, 2024 22:01 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground December 5, 2024 22:01 Inactive
@graphite-app
Copy link
Contributor

graphite-app bot commented Dec 5, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@jnsdls jnsdls mentioned this pull request Dec 5, 2024
Merged
@github-actions github-actions bot added the Dashboard Involves changes to the Dashboard. label Dec 5, 2024
@jnsdls Graphite App
Copy link
Member Author

jnsdls commented Dec 5, 2024 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

@jnsdls jnsdls marked this pull request as ready for review December 5, 2024 22:01
@github-actions
Copy link
Contributor

github-actions bot commented Dec 5, 2024 •
edited
Loading

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 45.71 KB (0%) 915 ms (0%) 2.6 s (+25% 🔺) 3.5 s
thirdweb (cjs) 106.29 KB (0%) 2.2 s (0%) 5.3 s (+4.12% 🔺) 7.5 s
thirdweb (minimal + tree-shaking) 5.58 KB (0%) 112 ms (0%) 372 ms (+146.24% 🔺) 484 ms
thirdweb/chains (tree-shaking) 506 B (0%) 10 ms (0%) 59 ms (+40.62% 🔺) 69 ms
thirdweb/react (minimal + tree-shaking) 18.44 KB (0%) 369 ms (0%) 623 ms (+49.6% 🔺) 992 ms

@codecov
Copy link

codecov bot commented Dec 5, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 45.88%. Comparing base (0babe2f) to head (b2b95a5).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #5636   +/-   ##
=======================================
  Coverage   45.88%   45.88%           
=======================================
  Files        1083     1083           
  Lines       56393    56393           
  Branches     4127     4127           
=======================================
  Hits        25874    25874           
  Misses      29827    29827           
  Partials      692      692
Flag Coverage Δ *Carryforward flag
legacy_packages 65.68% <ø> (ø) Carriedforward from 0babe2f
packages 41.14% <ø> (ø)

*This pull request uses carry forward flags. Click here to find out more.

@graphite-app
Copy link
Contributor

graphite-app bot commented Dec 5, 2024 •
edited
Loading

Merge activity

@jnsdls jnsdls force-pushed the 12-05-update_dependencies branch from 4f2d6b9 to 0babe2f Compare December 5, 2024 23:00
@jnsdls jnsdls requested a review from a team as a code owner December 5, 2024 23:00
@jnsdls jnsdls requested a review from a team December 5, 2024 23:00
@jnsdls jnsdls force-pushed the 12-05-fixes_dash-541 branch from 45ec5fd to b2b95a5 Compare December 5, 2024 23:01
@vercel vercel bot temporarily deployed to Preview – docs-v2 December 5, 2024 23:01 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground December 5, 2024 23:01 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui December 5, 2024 23:01 Inactive
Base automatically changed from 12-05-update_dependencies to main December 5, 2024 23:14
@graphite-app graphite-app bot merged commit b2b95a5 into main Dec 5, 2024
31 checks passed
@graphite-app graphite-app bot deleted the 12-05-fixes_dash-541 branch December 5, 2024 23:15
@vercel vercel bot temporarily deployed to Production – docs-v2 December 5, 2024 23:15 Inactive
@vercel vercel bot temporarily deployed to Production – thirdweb_playground December 5, 2024 23:15 Inactive
@vercel vercel bot temporarily deployed to Production – wallet-ui December 5, 2024 23:15 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MananTank MananTank MananTank approved these changes

@joaquim-verges joaquim-verges Awaiting requested review from joaquim-verges

@gregfromstl gregfromstl Awaiting requested review from gregfromstl

@jakubkrehel jakubkrehel Awaiting requested review from jakubkrehel

@arcoraven arcoraven Awaiting requested review from arcoraven

Assignees

No one assigned

Labels

Dashboard Involves changes to the Dashboard.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jnsdls @MananTank